feat: wallet coins filter #3117
Conversation
ice-priapus
requested review from
a team,
ice-brontes,
ice-hades and
ice-tychon
as code owners
| if (!tokenizedCommunityTokenTypeExists) { | ||
| await m.addColumn( | ||
| schema.coinsTable, | ||
| schema.coinsTable.tokenizedCommunityTokenType, | ||
| ); | ||
| } |
There was a problem hiding this comment.
should we write migration script to set token type for exist rows?
There was a problem hiding this comment.
As we haven't released the issue no user in prod has tokens, so no need to migrate yet. Also coin sync happens once a day, so it will overwrite the values
| SelectNetworkToReceiveNftRoute().push<void>(ref.context); | ||
| case WalletTabType.coins: | ||
| ReceiveCoinRoute().push<void>(context); | ||
| case WalletTabType.creatorTokens: |
There was a problem hiding this comment.
Ohh, we need to delete this page, so, then it's much easier here
There was a problem hiding this comment.
Balance page? I think we are using it
ice-morpheus
force-pushed
the
feature/wallet-coins-filter
branch
5 times, most recently
from
332922a to
420b915
Compare
ice-morpheus
force-pushed
the
feature/wallet-coins-filter
branch
from
420b915 to
0f0fad9
Compare
ice-morpheus
force-pushed
the
feature/wallet-coins-filter
branch
from
0f0fad9 to
edf4fea
Compare
| if (selectedFilter == TokenTypeFilter.all) { | ||
| return true; | ||
| } | ||
| return group.coins.any((coinInWallet) { |
There was a problem hiding this comment.
.any inside .where can be O(n^2) in worst case, it's better to avoid logic like that inside Widget.build methods.
There was a problem hiding this comment.
it was like this before my changes
final filteredGroups = groups?.where((group) {
return group.coins.any((coin) => coin.coin.isCreatorToken == isCreatorTokensTab);
we have only few coins per group, mostly one coin. I don't think it would be an issue here
ice-morpheus
force-pushed
the
feature/wallet-coins-filter
branch
4 times, most recently
from
41ebc5c to
b8a2983
Compare
ice-morpheus
force-pushed
the
feature/wallet-coins-filter
branch
from
b8a2983 to
72cdcb0
Compare
Description
Additional Notes
wallet token filter
Task ID
ION-5043
Type of Change
Screenshots (if applicable)
RPReplay_Final1768497332.MP4